[all-commits] [llvm/llvm-project] a622b2: [mlir][Transforms] Make `ConversionPatternRewriter...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a622b21f4607ee787c6fe63032a849c24374882b
      https://github.com/llvm/llvm-project/commit/a622b21f4607ee787c6fe63032a849c24374882b
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M flang/lib/Frontend/FrontendActions.cpp
    M mlir/include/mlir/Transforms/DialectConversion.h
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Make `ConversionPatternRewriter` constructor private (#82244)

`ConversionPatternRewriter` objects should not be constructed outside of
dialect conversions. Some IR modifications performed through a
`ConversionPatternRewriter` are reflected in the IR in a delayed fashion
(e.g., only when the dialect conversion is guaranteed to succeed). Using
a `ConversionPatternRewriter` outside of the dialect conversion is
incorrect API usage and can bring the IR in an inconsistent state.

Migration guide: Use `IRRewriter` instead of
`ConversionPatternRewriter`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications