[all-commits] [llvm/llvm-project] 049e14: [libc] Fix startup utilities failing to install in...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 049e142badfca3fae5c190c5d4b37acdd2e9c10c
      https://github.com/llvm/llvm-project/commit/049e142badfca3fae5c190c5d4b37acdd2e9c10c
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M libc/CMakeLists.txt
    M libc/lib/CMakeLists.txt
    M libc/startup/linux/CMakeLists.txt

  Log Message:
  -----------
  [libc] Fix startup utilities failing to install in full build mode (#82522)

Summary:
Currently, doing `ninja install` will fail in fullbuild mode due to the
startup utilities not being built by default. This was hidden previously
by the fact that if tests were run, it would build the startup utilities
and thus they would be present.

This patch solves this issue by making the `libc-startup` target a
dependncy on the final library. Furthermore we simply factor out the
library install directory into the base CMake directory next to the
include directory handling. This change makes the `crt` files get
installed in `lib/x86_64-unknown-linu-gnu` instead of just `lib`.

This fixes an error I had where doing a runtimes failed to install its
libraries because the install step always errored.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications