[all-commits] [llvm/llvm-project] 424717: [nfc]For InstrProfData.inc, clang-format functions...

[Mingming Liu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4247175d4536964322b129d1d3bbe6128da653bf
      https://github.com/llvm/llvm-project/commit/4247175d4536964322b129d1d3bbe6128da653bf
  Author: Mingming Liu <mingmingl at google.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M compiler-rt/include/profile/InstrProfData.inc
    M llvm/include/llvm/ProfileData/InstrProfData.inc

  Log Message:
  -----------
  [nfc]For InstrProfData.inc, clang-format functions and opt-out of formatting on the rest (#82057)

Without this, each time `InstrProfData.inc` is modified (like in
https://github.com/llvm/llvm-project/pull/81691), pre-commit CI
clang-format aggressively formats many lines in an unreadable way. Pull
request with red pre-commit checks are usually frowned upon.

* Use `// clang-format:<reason>` instead of `/* clang-format */`. The
former
[allows](https://github.com/llvm/llvm-project/blob/563ef306017a47d387f1c36dd562b172c1ad0626/clang/lib/Format/Format.cpp#L4108-L4113)
specifying a reason but the latter is
[not](https://github.com/llvm/llvm-project/blob/563ef306017a47d387f1c36dd562b172c1ad0626/clang/lib/Format/Format.cpp#L4105-L4106).
- Filed https://github.com/llvm/llvm-project/issues/82426 to track the
issue in clang-format.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications