[all-commits] [llvm/llvm-project] 4beb4d: [CostModel][X86] Add test coverage for icmp vs zero

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Wed Feb 21 08:20:06 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4beb4d5c72880ec69ef36bdebaed06c90cc5309b
      https://github.com/llvm/llvm-project/commit/4beb4d5c72880ec69ef36bdebaed06c90cc5309b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    A llvm/test/Analysis/CostModel/X86/icmp0.ll

  Log Message:
  -----------
  [CostModel][X86] Add test coverage for icmp vs zero

This is really to test for icmp vs constant - some icmp unsigned could fold to simpler comparisons, but costmodel analysis won't do this


  Commit: c16d0d14de40559eb3845a88b6434550dd1dcf77
      https://github.com/llvm/llvm-project/commit/c16d0d14de40559eb3845a88b6434550dd1dcf77
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    A llvm/test/Transforms/SimplifyCFG/X86/PR80122.ll

  Log Message:
  -----------
  [SimplifyCFG] Add test coverage for #80122


  Commit: 9978f6a10f37d12e1eecad0d4bfacd350d933ed7
      https://github.com/llvm/llvm-project/commit/9978f6a10f37d12e1eecad0d4bfacd350d933ed7
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86TargetTransformInfo.cpp
    M llvm/test/Analysis/CostModel/X86/icmp0.ll
    M llvm/test/Transforms/SimplifyCFG/X86/PR80122.ll

  Log Message:
  -----------
  [CostModel][X86] Reduce the extra costs for ICMP complex predicates when an operand is constant

In most cases, SETCC lowering will be able to simplify/commute the comparison by adjusting the constant.

TODO: We still need to adjust ExtraCost based on CostKind

Fixes #80122


Compare: https://github.com/llvm/llvm-project/compare/ffcdf47bc443...9978f6a10f37

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list