[all-commits] [llvm/llvm-project] ae28cd: [mlir][Transforms][NFC] Simplify `ArgConverter` state

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/simplify_arg_converter
  Home:   https://github.com/llvm/llvm-project
  Commit: ae28cd9e31ac6133574d0dc78be6454a69ab3830
      https://github.com/llvm/llvm-project/commit/ae28cd9e31ac6133574d0dc78be6454a69ab3830
  Author: Matthias Springer <springerm at google.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Simplify `ArgConverter` state

* When converting a block signature, `ArgConverter` creates a new block with the new signature and moves all operation from the old block to the new block. The new block is temporarily inserted into a region that is stored in `regionMapping`. The old block is not yet deleted, so that the conversion can be rolled back. `regionMapping` is not needed. Instead of moving the old block to a temporary region, it can just be unlinked. Block erasures are handles in the same way in the dialect conversion.
* `regionToConverter` is a mapping from regions to type converter. That field is never accessed within `ArgConverter`. It should be stored in `ConversionPatternRewriterImpl` instead.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications