[all-commits] [llvm/llvm-project] 4d4af1: [NFC][flang][OpenMP] Split `DataSharing` and `Clau...

[Kareem Ergawy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4d4af15c3fb671ed9f7eef9f29ebd6fde15618df
      https://github.com/llvm/llvm-project/commit/4d4af15c3fb671ed9f7eef9f29ebd6fde15618df
  Author: Kareem Ergawy <kareem.ergawy at amd.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M flang/lib/Lower/CMakeLists.txt
    R flang/lib/Lower/OpenMP.cpp
    A flang/lib/Lower/OpenMP/ClauseProcessor.cpp
    A flang/lib/Lower/OpenMP/ClauseProcessor.h
    A flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
    A flang/lib/Lower/OpenMP/DataSharingProcessor.h
    A flang/lib/Lower/OpenMP/OpenMP.cpp
    A flang/lib/Lower/OpenMP/ReductionProcessor.cpp
    A flang/lib/Lower/OpenMP/ReductionProcessor.h
    A flang/lib/Lower/OpenMP/Utils.cpp
    A flang/lib/Lower/OpenMP/Utils.h

  Log Message:
  -----------
  [NFC][flang][OpenMP] Split `DataSharing` and `Clause` processors (#81973)

This started as an experiment to reduce the compilation time of
iterating over `Lower/OpenMP.cpp` a bit since it is too slow at the
moment. Trying to do that, I split the `DataSharingProcessor`,
`ReductionProcessor`, and `ClauseProcessor` into their own files and
extracted some shared code into a util file. All of these new `.h/.cpp`
files as well as `OpenMP.cpp` are now under a `Lower/OpenMP/` directory.

This resulted is a slightly better organization of the OpenMP lowering
code and hence opening this NFC.

As for the compilation time, this unfortunately does not affect it much
(it shaves off a few seconds of `OpenMP.cpp` compilation) since from
what I learned the bottleneck is in `DirectivesCommon.h` and
`PFTBuilder.h` which both consume a lot of time in template
instantiation it seems.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications