[all-commits] [llvm/llvm-project] dfb70c: [mlir][EmitC] Remove `func.constant` from emitter ...

[Marius Brehler via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dfb70c3a7c65cd5143c942ad8a18f4177c16d74e
      https://github.com/llvm/llvm-project/commit/dfb70c3a7c65cd5143c942ad8a18f4177c16d74e
  Author: Marius Brehler <marius.brehler at iml.fraunhofer.de>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M mlir/docs/Dialects/emitc.md
    M mlir/lib/Target/Cpp/TranslateToCpp.cpp

  Log Message:
  -----------
  [mlir][EmitC] Remove `func.constant` from emitter (#82342)

As part of the renaming the Standard dialect to Func dialect, *support*
for the `func.constant` operation was added to the emitter. However, the
emitter cannot emit function types. Hence the emission for a snippet
like

```
%0 = func.constant @myfn : (f32) -> f32

func.func private @myfn(%arg0: f32) -> f32 {
  return %arg0 : f32
}
```

failes with `func.mlir:1:6: error: cannot emit type '(f32) -> f32'`.
This removes `func.constant` from the emitter.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications