[all-commits] [llvm/llvm-project] a4d461: [AMDGPU] Try decoding instructions longest first. ...

Jay Foad via All-commits all-commits at lists.llvm.org
Tue Feb 20 04:09:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a4d46157718573157d01a842d225267a5b2a7ef1
      https://github.com/llvm/llvm-project/commit/a4d46157718573157d01a842d225267a5b2a7ef1
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
    M llvm/lib/Target/AMDGPU/SOPInstructions.td

  Log Message:
  -----------
  [AMDGPU] Try decoding instructions longest first. NFCI. (#82014)

AMDGPUDisassembler::getInstruction tries decoding instructions using
different DecoderTables in a confusing order: first 96-bit instructions,
then some 64-bit, then 32-bit, then some more 64-bit.

This patch changes it to always try longer encodings first. The
motivation is to make getInstruction easier to understand, and to pave
the way for combining some 64-bit tables that do not need to be
separate.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list