[all-commits] [llvm/llvm-project] 43c7eb: [AMDGPU] Replace '.' with '-' in generic target na...

Pierre van Houtryve via All-commits all-commits at lists.llvm.org
Wed Feb 14 06:19:16 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43c7eb5d7b237bc18385f0a5529f1e4b8bf4d6a3
      https://github.com/llvm/llvm-project/commit/43c7eb5d7b237bc18385f0a5529f1e4b8bf4d6a3
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-02-14 (Wed, 14 Feb 2024)

  Changed paths:
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/test/Driver/amdgpu-macros.cl
    M clang/test/Driver/amdgpu-mcpu.cl
    M clang/test/Misc/target-invalid-cpu-note.c
    M llvm/docs/AMDGPUUsage.rst
    M llvm/lib/Object/ELFObjectFile.cpp
    M llvm/lib/Target/AMDGPU/GCNProcessors.td
    M llvm/lib/TargetParser/TargetParser.cpp
    M llvm/test/CodeGen/AMDGPU/directive-amdgcn-target.ll
    M llvm/test/CodeGen/AMDGPU/elf-header-flags-mach.ll
    M llvm/test/CodeGen/AMDGPU/generic-targets-require-v6.ll
    M llvm/test/CodeGen/AMDGPU/hsa-generic-target-features.ll
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.gather4.d16.dim.ll
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.image.sample.dim.ll
    M llvm/test/tools/llvm-objdump/ELF/AMDGPU/subtarget.ll
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [AMDGPU] Replace '.' with '-' in generic target names (#81718)

The dot is too confusing for tools. Output temporaries would have
'10.3-generic' so tools could parse it as an extension, device libs &
the associated clang driver logic are also confused by the dot.

After discussions, we decided it's better to just remove the '.' from
the target name than fix each issue one by one.




More information about the All-commits mailing list