[all-commits] [llvm/llvm-project] af97ed: [lldb] Refactor GetFormatFromCString to always che...

John Demme via All-commits all-commits at lists.llvm.org
Thu Feb 8 09:48:53 PST 2024


  Branch: refs/heads/users/teqdruid/mlir/python-liveobjects
  Home:   https://github.com/llvm/llvm-project
  Commit: af97edff70b0d9cb89729dc0d8af1d1ea101686e
      https://github.com/llvm/llvm-project/commit/af97edff70b0d9cb89729dc0d8af1d1ea101686e
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormatManager.h
    M lldb/source/Core/FormatEntity.cpp
    M lldb/source/DataFormatters/FormatManager.cpp
    M lldb/source/Interpreter/OptionArgParser.cpp

  Log Message:
  -----------
  [lldb] Refactor GetFormatFromCString to always check for partial matches  (NFC) (#81018)

Refactors logic in `ParseInternal` that was previously calling
`GetFormatFromCString` twice, once with `partial_match_ok` set to false,
and the second time set to true.

With this change, lldb formats (ie `%@`, `%S`, etc) are checked first.
If a format is not one of those, then `GetFormatFromCString` is called
once, and now always checks for partial matches.


  Commit: bef25ae297d6d246bf0fa8667c8b08f9d5e8dae7
      https://github.com/llvm/llvm-project/commit/bef25ae297d6d246bf0fa8667c8b08f9d5e8dae7
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86FixupVectorConstants.cpp
    M llvm/test/CodeGen/X86/pr81136.ll

  Log Message:
  -----------
  [X86] X86FixupVectorConstants - use explicit register bitwidth for the loaded vector instead of using constant pool bitwidth

Fixes #81136 - we might be loading from a constant pool entry wider than the destination register bitwidth, affecting the vextload scale calculation.

ConvertToBroadcastAVX512 doesn't yet set an explicit bitwidth (it will default to the constant pool bitwidth) due to difficulties in looking up the original register width through the fold tables, but as we only use rebuildSplatCst this shouldn't cause any miscompilations, although it might prevent folding to broadcast if only the lower bits match a splatable pattern.


  Commit: c8d431e0ed6ab6276bf45d1c36466faad8e4e4d1
      https://github.com/llvm/llvm-project/commit/c8d431e0ed6ab6276bf45d1c36466faad8e4e4d1
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-buildvec-of-binop.ll

  Log Message:
  -----------
  [riscv] Add test coverage in advance of a upcoming fix

This is a reduced test case for a fix for the issue identified in
https://github.com/llvm/llvm-project/issues/80910.


  Commit: d32118b3584778a23eb9b327e0c303983710c7c7
      https://github.com/llvm/llvm-project/commit/d32118b3584778a23eb9b327e0c303983710c7c7
  Author: John Demme <john.demme at microsoft.com>
  Date:   2024-02-08 (Thu, 08 Feb 2024)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormatManager.h
    M lldb/source/Core/FormatEntity.cpp
    M lldb/source/DataFormatters/FormatManager.cpp
    M lldb/source/Interpreter/OptionArgParser.cpp
    M llvm/lib/Target/X86/X86FixupVectorConstants.cpp
    M llvm/test/CodeGen/RISCV/rvv/fixed-vectors-buildvec-of-binop.ll
    M llvm/test/CodeGen/X86/pr81136.ll

  Log Message:
  -----------
  Merge branch 'main' into users/teqdruid/mlir/python-liveobjects


Compare: https://github.com/llvm/llvm-project/compare/0a312e870855...d32118b35847


More information about the All-commits mailing list