[all-commits] [llvm/llvm-project] d9a987: [TextAPI] Rename SymbolKind to EncodeKind (#79622)

Cyndy Ishida via All-commits all-commits at lists.llvm.org
Fri Jan 26 16:13:03 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d9a9872ec4760762fdc467ef283cea302a3742e5
      https://github.com/llvm/llvm-project/commit/d9a9872ec4760762fdc467ef283cea302a3742e5
  Author: Cyndy Ishida <cyndy_ishida at apple.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M llvm/include/llvm/TextAPI/InterfaceFile.h
    M llvm/include/llvm/TextAPI/Symbol.h
    M llvm/include/llvm/TextAPI/SymbolSet.h
    M llvm/lib/Object/TapiFile.cpp
    M llvm/lib/TextAPI/RecordVisitor.cpp
    M llvm/lib/TextAPI/RecordsSlice.cpp
    M llvm/lib/TextAPI/Symbol.cpp
    M llvm/lib/TextAPI/SymbolSet.cpp
    M llvm/lib/TextAPI/TextStub.cpp
    M llvm/lib/TextAPI/TextStubV5.cpp
    M llvm/tools/llvm-ifs/llvm-ifs.cpp
    M llvm/tools/llvm-readtapi/DiffEngine.cpp
    M llvm/tools/llvm-readtapi/DiffEngine.h
    M llvm/unittests/TextAPI/TextStubHelpers.h
    M llvm/unittests/TextAPI/TextStubV1Tests.cpp
    M llvm/unittests/TextAPI/TextStubV2Tests.cpp
    M llvm/unittests/TextAPI/TextStubV3Tests.cpp
    M llvm/unittests/TextAPI/TextStubV4Tests.cpp
    M llvm/unittests/TextAPI/TextStubV5Tests.cpp

  Log Message:
  -----------
  [TextAPI] Rename SymbolKind to EncodeKind (#79622)

A distinction that doesn't _usually_ matter is that the
MachO::SymbolKind is really a mapping of entries in TBD files not
symbols. To better understand this, rename the enum so it represents an
encoding mapped to TBDs as opposed to symbols alone.

For example, it can be a bit confusing that "GlobalSymbol" is a enum
value when all of those values can represent a GlobalSymbol.




More information about the All-commits mailing list