[all-commits] [llvm/llvm-project] 3bece3: [Exegesis] Do not assume the size and layout of th...

Min-Yih Hsu via All-commits all-commits at lists.llvm.org
Fri Jan 26 15:47:38 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3bece3d72d1323af6b2418b13281e66b583f25b3
      https://github.com/llvm/llvm-project/commit/3bece3d72d1323af6b2418b13281e66b583f25b3
  Author: Min-Yih Hsu <min.hsu at sifive.com>
  Date:   2024-01-26 (Fri, 26 Jan 2024)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/Assembler.cpp

  Log Message:
  -----------
  [Exegesis] Do not assume the size and layout of the assembled snippet (#79636)

Currently llvm-exegesis assumes that there will only be 3 symbols in the
snippet object, in which the benchmarking function 'foo' is always the
last symbol.

These assumptions do not hold for object file formats of other targets
we support downstream. I think it would be more ideal to generalize this
part of the logics into a simple search on all symbols, as proposed by
this patch.




More information about the All-commits mailing list