[all-commits] [llvm/llvm-project] ceb196: [llvm-exegesis] Validate that address annotations ...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ceb196d9903f4db7250bbc6c8da13eeae1b85886
      https://github.com/llvm/llvm-project/commit/ceb196d9903f4db7250bbc6c8da13eeae1b85886
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2023-12-15 (Fri, 15 Dec 2023)

  Changed paths:
    A llvm/test/tools/llvm-exegesis/X86/latency/memory-annotations-alignment-page-boundary.s
    A llvm/test/tools/llvm-exegesis/X86/latency/memory-annotations-snippet-alignment-page-boundary.s
    M llvm/tools/llvm-exegesis/lib/Assembler.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/SnippetFile.cpp

  Log Message:
  -----------
  [llvm-exegesis] Validate that address annotations are aligned (#75554)

This patch adds in validation at two different levels that address
annotations are page aligned. This is necessary as otherwise the mmap
calls will fail as MAP_FIXED/MAP_FIXED_NOREPLACE require page aligned
addresses. This happens silently in the subprocess. This patch adds
validation at snippet parsing time to give feedback to the user and also
adds asserts at code generation/address usage time to ensure that other
users of the Exegesis APIs conform to the same requirements.