[all-commits] [llvm/llvm-project] 64addd: [libc++][test] Enhance ADDITIONAL_COMPILE_FLAGS, u...

[Stephan T. Lavavej via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64addd65210db59c8cb3794f792720e03e25b5af
      https://github.com/llvm/llvm-project/commit/64addd65210db59c8cb3794f792720e03e25b5af
  Author: Stephan T. Lavavej <stl at nuwen.net>
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
    M libcxx/test/std/algorithms/alg.modifying.operations/alg.replace/ranges.replace.pass.cpp
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.find/find.pass.cpp
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.find/ranges.find.pass.cpp
    M libcxx/test/std/atomics/atomics.types.generic/general.compile.pass.cpp
    M libcxx/test/std/atomics/atomics.types.generic/pointer.compile.pass.cpp
    M libcxx/test/std/concepts/concepts.lang/concept.default.init/default_initializable.compile.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_range.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_range.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_range.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_range.pass.cpp
    M libcxx/test/std/containers/sequences/array/array.tuple/get.verify.cpp
    M libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/insert_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/insert_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.multiset/insert_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.set/insert_range.pass.cpp
    M libcxx/test/std/containers/views/mdspan/layout_stride/deduction.pass.cpp
    M libcxx/test/std/containers/views/mdspan/mdspan/conversion.pass.cpp
    M libcxx/test/std/depr/depr.c.headers/setjmp_h.compile.pass.cpp
    M libcxx/test/std/depr/depr.numeric.limits.has.denorm/deprecated.verify.cpp
    M libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/buffered_reads.pass.cpp
    M libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/buffered_writes.pass.cpp
    M libcxx/test/std/iterators/iterator.primitives/iterator.operations/advance.pass.cpp
    M libcxx/test/std/language.support/support.runtime/csetjmp.pass.cpp
    M libcxx/test/std/ranges/range.adaptors/range.lazy.split/constraints.compile.pass.cpp
    M libcxx/test/std/ranges/range.utility/range.utility.conv/to.pass.cpp
    M libcxx/test/std/strings/basic.string/string.cons/from_range_deduction.pass.cpp
    M libcxx/test/std/thread/thread.condition/notify_all_at_thread_exit_lwg3343.pass.cpp
    M libcxx/test/std/thread/thread.jthread/assign.move.pass.cpp
    M libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/result_of11.pass.cpp
    M libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp
    M libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move.pass.cpp
    M libcxx/test/std/utilities/variant/variant.variant/implicit_ctad.pass.cpp
    M libcxx/test/support/msvc_stdlib_force_include.h
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libc++][test] Enhance ADDITIONAL_COMPILE_FLAGS, use TEST_MEOW_DIAGNOSTIC_IGNORED sparingly (#75317)

This is the last PR that's needed (for now) to get libc++'s tests
working with MSVC's STL.

The ADDITIONAL_COMPILE_FLAGS machinery is very useful, but also very
problematic for MSVC, as it doesn't understand most of Clang's compiler
options. We've been dealing with this by simply marking anything that
uses ADDITIONAL_COMPILE_FLAGS as FAIL or SKIPPED, but that creates
significant gaps in test coverage.

Fortunately, ADDITIONAL_COMPILE_FLAGS also supports "features", which
can be slightly enhanced to send Clang-compatible and MSVC-compatible
options to the right compilers.

This patch adds the gcc-style-warnings and cl-style-warnings Lit features,
and uses that to pass the appropriate warning flags to tests. It also uses
TEST_MEOW_DIAGNOSTIC_IGNORED for a few local suppressions of MSVC
warnings.