[all-commits] [llvm/llvm-project] f956bf: [llvm][cmake] Use $<CONFIG> instead of ${CMAKE_CFG...

Michael Spencer via All-commits all-commits at lists.llvm.org
Thu Dec 14 14:03:34 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f956bfe169c7debd72acd22b124e5ae78174b3a0
      https://github.com/llvm/llvm-project/commit/f956bfe169c7debd72acd22b124e5ae78174b3a0
  Author: Michael Spencer <bigcheesegs at gmail.com>
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
    M llvm/tools/llvm-config/CMakeLists.txt

  Log Message:
  -----------
  [llvm][cmake] Use $<CONFIG> instead of ${CMAKE_CFG_INTDIR} for llvm-config (#75417)

${CMAKE_CFG_INTDIR} does not work correctly for llvm-config when
building with the Ninja Multi-Config generator. It tries to find files
in the ${CONFIGURATION} directory. Using the $<CONFIG> generator
expression instead fixes this.

Really this needs to be done everywhere as ${CMAKE_CFG_INTDIR} is
deprecated as of 3.21 (LLVM's current min version is 3.20), but this is
sufficient to get `check-llvm` to pass.

See https://cmake.org/cmake/help/latest/variable/CMAKE_CFG_INTDIR.html




More information about the All-commits mailing list