[all-commits] [llvm/llvm-project] 5bc1ad: Revert "lldb: Cache string hash during ConstString...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5bc1adff69315dcef670e9fcbe04067b5d5963fb
      https://github.com/llvm/llvm-project/commit/5bc1adff69315dcef670e9fcbe04067b5d5963fb
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
    M lldb/source/Utility/ConstString.cpp
    M llvm/lib/Support/StringMap.cpp

  Log Message:
  -----------
  Revert "lldb: Cache string hash during ConstString pool queries/insertions"

Underlying StringMap API for providing a hash has caused some problems
(observed a crash in lld) - so reverting this until I can figure out/fix
what's going on there.

This reverts commit 52ba075571958e2fec8d871ddfa1ef56486b86d3.
This reverts commit 2e197602305be18b963928e6ae024a004a95af6d.


  Commit: f976719fb2cb23364957e5993f7fc3684ee15391
      https://github.com/llvm/llvm-project/commit/f976719fb2cb23364957e5993f7fc3684ee15391
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2023-12-14 (Thu, 14 Dec 2023)

  Changed paths:
    M llvm/include/llvm/ADT/StringMap.h
    M llvm/lib/Support/StringMap.cpp
    M llvm/unittests/ADT/StringMapTest.cpp

  Log Message:
  -----------
  Revert "[ADT][StringMap] Add ability to precompute and reuse the string hash"

Crash identified internally in lld's use of StringMap in
`compareSections`. Will investigate offline before recommitting.

This reverts commit 67c631d283fc96d652304199cd625be426b98f8e.


Compare: https://github.com/llvm/llvm-project/compare/7537c3c452df...f976719fb2cb