[all-commits] [llvm/llvm-project] 590001: [dsymutil] Improve missing symbol warning message ...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 590001431b44ec4f3209db5a4d50cc8ebc959a93
      https://github.com/llvm/llvm-project/commit/590001431b44ec4f3209db5a4d50cc8ebc959a93
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M llvm/test/tools/dsymutil/ARM/extern-alias.test
    A llvm/test/tools/dsymutil/ARM/missing-symbol-warning.test
    M llvm/test/tools/dsymutil/ARM/static-archive-collision.test
    A llvm/test/tools/dsymutil/Inputs/private/tmp/warning/test.o
    A llvm/test/tools/dsymutil/Inputs/private/tmp/warning/test.out
    M llvm/test/tools/dsymutil/X86/alias.test
    M llvm/test/tools/dsymutil/X86/thinlto.test
    M llvm/tools/dsymutil/MachODebugMapParser.cpp

  Log Message:
  -----------
  [dsymutil] Improve missing symbol warning message (#75378)

The current warning emitted by dsymutil when it can't find a symbol in
an object file is worded rather poorly:

```
could not find object file symbol for symbol _foo
```

It's also lacking information that makes the warning actionable, such as
the object file it's looking at. This patch rewords the warning and adds
the object file path to the warning:

```
could not find symbol '_foo' in object file 'test.o'
```

rdar://119621065