[all-commits] [llvm/llvm-project] eaa115: [libc] fix -Wmacro-redefined (#75261)

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Wed Dec 13 08:39:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eaa11526c873b65a9dc0aaf0ebaf66de3db8ed21
      https://github.com/llvm/llvm-project/commit/eaa11526c873b65a9dc0aaf0ebaf66de3db8ed21
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M libc/include/llvm-libc-macros/linux/fcntl-macros.h
    M libc/include/llvm-libc-macros/linux/sys-stat-macros.h
    M libc/src/__support/File/linux/file.cpp

  Log Message:
  -----------
  [libc] fix -Wmacro-redefined (#75261)

When building with compiler-rt enabled, warnings such as the following
are
observed:


llvm-project/llvm/build/projects/compiler-rt/../libc/include/llvm-libc-macros/linux/sys-stat-macros.h:46:9:
    warning: 'S_IXOTH' macro redefined [-Wmacro-redefined]
    #define S_IXOTH 00001
            ^

llvm-project/llvm/build/projects/compiler-rt/../libc/include/llvm-libc-macros/linux/fcntl-macros.h:61:9:
    note: previous definition is here
    #define S_IXOTH 01
            ^
It looks like we have these multiply defined. Deduplicate these flags;
users
should expect to find them in sys/stat.h. S_FIFO was wrong anyways
(should
have been S_IFIFO).




More information about the All-commits mailing list