[all-commits] [llvm/llvm-project] 785e09: [libc++] Fix incomplete user-defined ctype special...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Dec 13 07:27:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 785e0945ce49cf5be0d8fcc0874ad6a5c94fc920
      https://github.com/llvm/llvm-project/commit/785e0945ce49cf5be0d8fcc0874ad6a5c94fc920
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/user_defined_char_type.pass.cpp

  Log Message:
  -----------
  [libc++] Fix incomplete user-defined ctype specialization in test (#74630)

The specialization was non-conforming because it was missing a bunch of
member functions. Those were missing probably just as an oversight
coupled with a bit of laziness -- the rule that user-defined
specializations need to match the base template is usually OK to take
with a grain of salt, but not when the code is supposed to be portable,
which our test suite aims to be.

Fixes #74214




More information about the All-commits mailing list