[all-commits] [llvm/llvm-project] 4b6413: [DebugInfo][RemoveDIs] Switch some insertion routi...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b64138ba485fd0fca69613e429e585ee4b67575
      https://github.com/llvm/llvm-project/commit/4b64138ba485fd0fca69613e429e585ee4b67575
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M llvm/lib/CodeGen/CodeGenPrepare.cpp
    M llvm/lib/Transforms/Scalar/LICM.cpp
    M llvm/lib/Transforms/Utils/LoopRotationUtils.cpp

  Log Message:
  -----------
  [DebugInfo][RemoveDIs] Switch some insertion routines to use iterators (#75330)

As part of RemoveDIs, we need instruction insertion to be done with
iterators rather than instruction pointers, so that we can communicate
some debug-info facts about the position. This patch is an entirely
mechanical replacement of Instruction * with BasicBlock::iterator, plus
using insertBefore to insert some instructions because we don't have
iterator-taking constructors yet.

Sadly it's not NFC because it causes dbg.value intrinsics / their
DPValue equivalents to shift location.