[all-commits] [llvm/llvm-project] a9af31: Revert "[libc][NFC] Implement `FPBits` in terms of...

Guillaume Chatelet via All-commits all-commits at lists.llvm.org
Wed Dec 13 00:55:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a9af317fbecae00508b3f8c752af3dbcc06e2fcb
      https://github.com/llvm/llvm-project/commit/a9af317fbecae00508b3f8c752af3dbcc06e2fcb
  Author: Guillaume Chatelet <gchatelet at google.com>
  Date:   2023-12-13 (Wed, 13 Dec 2023)

  Changed paths:
    M libc/src/__support/FPUtil/FPBits.h
    M libc/src/__support/FPUtil/Hypot.h
    M libc/src/__support/FPUtil/generic/FMod.h
    M libc/src/__support/FPUtil/x86_64/LongDoubleBits.h
    M libc/src/__support/str_to_float.h
    M libc/src/math/generic/acoshf.cpp
    M libc/src/math/generic/asinhf.cpp
    M libc/src/math/generic/atanhf.cpp
    M libc/src/math/generic/erff.cpp
    M libc/src/math/generic/explogxf.h
    M libc/src/math/generic/inv_trigf_utils.h
    M libc/src/math/generic/log.cpp
    M libc/src/math/generic/log10.cpp
    M libc/src/math/generic/log1p.cpp
    M libc/src/math/generic/log2.cpp
    M libc/src/math/generic/sinhf.cpp
    M libc/src/math/generic/tanhf.cpp

  Log Message:
  -----------
  Revert "[libc][NFC] Implement `FPBits` in terms of `FloatProperties` to reduce clutter" (#75304)

Reverts llvm/llvm-project#75196

GCC complains about change of meaning for `FPBits`
```
/home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/llvm-project/libc/src/__support/FPUtil/generic/FMod.h:188:9: error: declaration of ‘using FPBits = struct __llvm_libc_18_0_0_git::fputil::FPBits<T>’ changes meaning of ‘FPBits’ [-fpermissive]
  188 |   using FPBits = FPBits<T>;
      |         ^~~~~~
```

I'll reland with a different name.




More information about the All-commits mailing list