[all-commits] [llvm/llvm-project] 8eff57: Add missing dep on MLIRToLLVMIRTranslationRegistra...
Stella Laurenzo via All-commits
all-commits at lists.llvm.org
Tue Dec 12 14:10:20 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 8eff5704829ba5edd28754fd9ec7665b34fde22a
https://github.com/llvm/llvm-project/commit/8eff5704829ba5edd28754fd9ec7665b34fde22a
Author: Stella Laurenzo <stellaraccident at gmail.com>
Date: 2023-12-12 (Tue, 12 Dec 2023)
Changed paths:
M mlir/tools/mlir-opt/CMakeLists.txt
M mlir/tools/mlir-opt/mlir-opt.cpp
Log Message:
-----------
Add missing dep on MLIRToLLVMIRTranslationRegistration to mlir-opt. (#75111)
I was not able to fully triage why this just started failing on one of
our bots as it seems that the use was added 4 months ago. I would assume
that it was accidentally coming in transitively in some way as the dep
was definitely missing.
For context, this started failing in [our
byo_llvm](https://github.com/openxla/iree/blob/main/build_tools/llvm/byo_llvm.sh)
build on a stock build of MLIR on top of an existing LLVM. We were
getting:
```
ld.lld: error: undefined symbol: mlir::registerSPIRVDialectTranslation(mlir::DialectRegistry&) >>> referenced by mlir-opt.cpp
>>> tools/mlir-opt/CMakeFiles/mlir-opt.dir/mlir-opt.cpp.o:(main)
```
More information about the All-commits
mailing list