[all-commits] [llvm/llvm-project] 81d1df: [SpecialCaseList] Use glob by default (#74809)

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Dec 11 15:30:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 81d1df2a39f0616be4b530cbf86b3f575442a347
      https://github.com/llvm/llvm-project/commit/81d1df2a39f0616be4b530cbf86b3f575442a347
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M clang/docs/SanitizerSpecialCaseList.rst
    M llvm/lib/Support/SpecialCaseList.cpp
    M llvm/unittests/Support/SpecialCaseListTest.cpp

  Log Message:
  -----------
  [SpecialCaseList] Use glob by default (#74809)

https://reviews.llvm.org/D154014 addes glob support and enables it when
`#!special-case-list-v2` is the first line. This patch makes the glob
support the default (faster than regex after
https://reviews.llvm.org/D156046) and switches to the deprecated regex
support if `#!special-case-list-v1` is the first line.

I have surveyed many ignore lists. All ignore lists I find only use
basic `*` `.` and don't use regex metacharacters such as `(` and `)`.
(As neither `src:` nor `fun:` benefits from using regex.)
They are unaffected by the transition (with a caution that regex
`src:x/a.pb.*` matches `x/axpbx` but glob `src:x/a.pb.*` doesn't).

There is no deprecating warning. If a user finds
`#!special-case-list-v1`, they shall read that the old syntax is
deprecated.

Link:
https://discourse.llvm.org/t/use-glob-instead-of-regex-for-specialcaselists/71666




More information about the All-commits mailing list