[all-commits] [llvm/llvm-project] 9071a1: [llvm][Attributor] Strip AddressSpaceCast from 'co...

[Youngsuk Kim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9071a15d4b90be1c0f57b6d7540097662b31963a
      https://github.com/llvm/llvm-project/commit/9071a15d4b90be1c0f57b6d7540097662b31963a
  Author: Youngsuk Kim <joseph942010 at gmail.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/AttributorAttributes.cpp

  Log Message:
  -----------
  [llvm][Attributor] Strip AddressSpaceCast from 'constructPointer' (#74742)

* Remove pointer AddressSpaceCast in function `constructPointer`
* Remove 1st parameter (`ResTy`) of function `constructPointer`

1st input argument to function `constructPointer` in all 4 call-sites is
`ptr addrspace(0)`. Function `constructPointer` performs a pointer
AddressSpaceCast to `ResTy`, making the returned pointer have type `ptr
addrspace(0)` in all 4 call-sites.

Unless there's a clear reason to discard the addrspace info of input
parameter `Ptr`, I think we should keep and forward that info to the
returned pointer of `constructPointer`.

Opaque ptr cleanup effort.