[all-commits] [llvm/llvm-project] 162248: [SymbolFileDWARF][NFC] Remove duplicated code chec...

Felipe de Azevedo Piovezan via All-commits all-commits at lists.llvm.org
Mon Dec 11 03:01:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 162248c22dcfa0674efd339f35717ea711b8e025
      https://github.com/llvm/llvm-project/commit/162248c22dcfa0674efd339f35717ea711b8e025
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-12-11 (Mon, 11 Dec 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

  Log Message:
  -----------
  [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (#74773)

There was duplicated (and complex) code querying whether tags were
type-like tags (i.e. class or struct); this has been factored out into a
helper function.

There was also a comment about not comparing identical DIEs without ever
performing that check; this comment has been removed. It was likely a
result of copy paste from another function in this same file which
actually does that check.




More information about the All-commits mailing list