[all-commits] [llvm/llvm-project] f49bca: [CMake] Make specifying invalid build type a fatal...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f49bca9b5a4a5a3d9d8135b4c17e7f1e7dcecdde
      https://github.com/llvm/llvm-project/commit/f49bca9b5a4a5a3d9d8135b4c17e7f1e7dcecdde
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    M llvm/CMakeLists.txt
    M llvm/docs/CMake.rst

  Log Message:
  -----------
  [CMake] Make specifying invalid build type a fatal error (#72021)

This patch makes it so that specifying an invalid value for
CMAKE_BUILD_TYPE is a fatal error. Having this simply as a warning has
caused me (and probably others) a decent amount of headache. The check
was present before, but was proposed to be modified to a warning in
https://github.com/llvm/llvm-project/issues/60975 and changed to a
warning in c75dbeda15c10424910ddc83a9ff7669776c19ac. This patch
reenables that behavior to hopefully reduce frustration for people
building LLVM in the common case while still allowing for alternative
build types to be setup without needing to perform source modification
through the addition of a CMake flag.