[all-commits] [llvm/llvm-project] 0718c1: [llvm-exegesis] Fix preservation of RDI in subproc...

Aiden Grossman via All-commits all-commits at lists.llvm.org
Thu Nov 16 10:27:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0718c1a8405ac130d72cd3525befed2911618cc7
      https://github.com/llvm/llvm-project/commit/0718c1a8405ac130d72cd3525befed2911618cc7
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2023-11-16 (Thu, 16 Nov 2023)

  Changed paths:
    A llvm/test/tools/llvm-exegesis/X86/latency/subprocess-preserved-registers.s
    M llvm/tools/llvm-exegesis/lib/X86/Target.cpp

  Log Message:
  -----------
  [llvm-exegesis] Fix preservation of RDI in subprocess mode (#72458)

I made a typo at some point while doing the subprocess implementation,
trying to pop RIP from the stack. For whatever reason, this ends up as
popq %rax after being JITed, which means we aren't properly preserving
the value of %rdi.

Regression test added.

This fixes #72188.




More information about the All-commits mailing list