[all-commits] [llvm/llvm-project] 27156d: Revert "[TSAN] Add __tsan_check_no_mutexes_held he...

Hans via All-commits all-commits at lists.llvm.org
Tue Nov 7 07:09:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 27156dd575d34980c21f97fae4bfbd47a8ca16de
      https://github.com/llvm/llvm-project/commit/27156dd575d34980c21f97fae4bfbd47a8ca16de
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M compiler-rt/include/sanitizer/tsan_interface.h
    M compiler-rt/lib/tsan/rtl/tsan.syms.extra
    M compiler-rt/lib/tsan/rtl/tsan_debugging.cpp
    M compiler-rt/lib/tsan/rtl/tsan_interface_ann.cpp
    M compiler-rt/lib/tsan/rtl/tsan_report.cpp
    M compiler-rt/lib/tsan/rtl/tsan_report.h
    M compiler-rt/lib/tsan/rtl/tsan_suppressions.cpp
    R compiler-rt/test/tsan/mutex_held_wrong_context.cpp

  Log Message:
  -----------
  Revert "[TSAN] Add __tsan_check_no_mutexes_held helper (#69372)"

The new lit test fails, see comment on the PR. This also reverts
the follow-up commit, see below.

> This adds a new helper that can be called from application code to
> ensure that no mutexes are held on specific code paths. This is useful
> for multiple scenarios, including ensuring no locks are held:
>
> - at thread exit
> - in peformance-critical code
> - when a coroutine is suspended (can cause deadlocks)
>
> See this discourse thread for more discussion:
>
> https://discourse.llvm.org/t/add-threadsanitizer-check-to-prevent-coroutine-suspending-while-holding-a-lock-potential-deadlock/74051

This reverts commit bd841111f340a73eb23c1be70ff1be4c8a6afb0c.
This reverts commit 16a395b74d35c564f6f36ba4a167950a323badd9.




More information about the All-commits mailing list