[all-commits] [llvm/llvm-project] 8ee9da: [C++20] [Modules] Don't import function bodies fro...

[Chuanqi Xu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ee9da02325cebf359de987f7ac8e1d3d629affe
      https://github.com/llvm/llvm-project/commit/8ee9da02325cebf359de987f7ac8e1d3d629affe
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2023-11-07 (Tue, 07 Nov 2023)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/CodeGenCXX/module-funcs-from-imports.cppm
    M clang/test/CodeGenCXX/partitions.cpp
    A clang/test/Modules/cxx20-importing-function-bodies.cppm
    M clang/test/Modules/no-import-func-body.cppm

  Log Message:
  -----------
  [C++20] [Modules] Don't import function bodies from other module units even with optimizations (#71031)

Close https://github.com/llvm/llvm-project/issues/60996.

Previously, clang will try to import function bodies from other module
units to get more optimization oppotunities as much as possible. Then
the motivation becomes the direct cause of the above issue.

However, according to the discussion in SG15, the behavior of importing
function bodies from other module units breaks the ABI compatibility. It
is unwanted. So the original behavior of clang is incorrect. This patch
choose to not import function bodies from other module units in all
cases to follow the expectation.

Note that the desired optimized BMI idea is discarded too. Since it will
still break the ABI compatibility after we import function bodies
seperately.

The release note will be added seperately.

There is a similar issue for variable definitions. I'll try to handle
that in a different commit.