[all-commits] [llvm/llvm-project] 30ca16: [mlir][spirv] Handle failed conversions of struct ...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 30ca16ec87206294f4ad0e9688c88f32421b343e
      https://github.com/llvm/llvm-project/commit/30ca16ec87206294f4ad0e9688c88f32421b343e
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2023-10-30 (Mon, 30 Oct 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVTypes.h
    M mlir/lib/Conversion/SPIRVToLLVM/SPIRVToLLVM.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp
    M mlir/test/Conversion/SPIRVToLLVM/spirv-types-to-llvm-invalid.mlir

  Log Message:
  -----------
  [mlir][spirv] Handle failed conversions of struct elements (#70005)

LLVMStructTypes could be emitted with some null elements. This caused a
crash later in the LLVMDialect verifier.

We now use `convertTypes` and check that all types were successfully converted before passing them to the `LLVMStructType` constructor.

See #59990