[all-commits] [llvm/llvm-project] 2228b3: Revert "Revert "[InstCombine] Add oneuse checks to...

Amara Emerson via All-commits all-commits at lists.llvm.org
Sat Oct 28 03:12:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2228b35f93256449ca2524ed38dd068b87163efc
      https://github.com/llvm/llvm-project/commit/2228b35f93256449ca2524ed38dd068b87163efc
  Author: Amara Emerson <amara at apple.com>
  Date:   2023-10-28 (Sat, 28 Oct 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
    M llvm/test/Transforms/InstCombine/ashr-icmp-minmax-idiom-break.ll
    M llvm/test/Transforms/InstCombine/icmp-shr-lt-gt.ll
    M llvm/test/Transforms/InstCombine/icmp-shr.ll
    M llvm/test/Transforms/PhaseOrdering/icmp-ashr-breaking-select-idiom.ll

  Log Message:
  -----------
  Revert "Revert "[InstCombine] Add oneuse checks to shr + cmp constant folds.""

This reverts commit d37b283cdd37feca5ea71456cf350005add268e7.

There was a simple logic bug in the else path. Tests codegen is different with
the fix.




More information about the All-commits mailing list