[all-commits] [llvm/llvm-project] 631e29: [mlir][bytecode] Fix D155919 and enable backward-c...

Matteo Franciolini via All-commits all-commits at lists.llvm.org
Fri Oct 27 23:13:35 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 631e2911ea298bc12564df8acd16bba89790426a
      https://github.com/llvm/llvm-project/commit/631e2911ea298bc12564df8acd16bba89790426a
  Author: Matteo Franciolini <m_franciolini at apple.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir][bytecode] Fix D155919 and enable backward-compatibility and back-deployment between version 5 and version 6 of the bytecode encoding (#70498)

Before D155919, when a dialect was leveraging properties to store
attributes with `usePropertiesForAttributes`, the operand segment sizes
attribute was emitted in the property section in sorted order together
with all the other attributes of an op. After D155919, version 5 of the
bytecode was emitting and parsing operand segment sizes after all the
properties of an op, breaking backward compatibility and back
deployment. This patch fixes the emission ordering and allows to parse
bytecode files emitted before (D155919) with version 5 of MLIR bytecode.
The patch also enables to emit correctly version 5 of MLIR bytecode.




More information about the All-commits mailing list