[all-commits] [llvm/llvm-project] cb950c: [libc++] Make sure we implement and test LWG2280 p...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb950c9dc9bff37367068310bdfad75c7274915c
      https://github.com/llvm/llvm-project/commit/cb950c9dc9bff37367068310bdfad75c7274915c
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M libcxx/include/__iterator/access.h
    M libcxx/include/iterator
    M libcxx/test/std/iterators/iterator.range/begin-end.array.pass.cpp
    M libcxx/test/std/iterators/iterator.range/begin-end.container.pass.cpp

  Log Message:
  -----------
  [libc++] Make sure we implement and test LWG2280 properly (#67670)

We did not mark std::begin/std::end as noexcept for C-style arrays, we
did not have conditional noexcept on cbegin/cend, and we did not mark
array cbegin/cend as constexpr in all Standard modes. Since this is a
LWG issue, we should implement it as a DR in all Standard modes as
usual.

This patch fixes these issues and adds test coverage. Fixes #67471.