[all-commits] [llvm/llvm-project] e6e55e: [mlir][vector] Fix off-by-one error in `getTransfe...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e6e55e620bb6adba50c15ff52e177b5c68e38d61
      https://github.com/llvm/llvm-project/commit/e6e55e620bb6adba50c15ff52e177b5c68e38d61
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-10-27 (Fri, 27 Oct 2023)

  Changed paths:
    M mlir/include/mlir/Interfaces/VectorInterfaces.td
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/Vector/canonicalize.mlir

  Log Message:
  -----------
  [mlir][vector] Fix off-by-one error in `getTransferChunkAccessed` (#70292)

If a dimension does not appear in the permutation map of a vector
transfer op, the size of the accessed slice in that dimension is `1`.
Before this fix, `getTransferChunkAccessed` used to return `0` for such
dimensions, which would means that `0` elements in the underlying
tensor/memref are accessed.

Note: There is no test case that fails due to this bug and because this
interface method is currently only used in one place, it is hard to
write a regression test. This fix is in preparation of subset hoisting
functionality that will be added in subsequent commits.