[all-commits] [llvm/llvm-project] f9ead4: [AST] Only dump desugared type when visibly differ...

[Jessica Clarke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f9ead46931aef2978ddf350ba6523638175d7861
      https://github.com/llvm/llvm-project/commit/f9ead46931aef2978ddf350ba6523638175d7861
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M clang/docs/HowToSetupToolingForLLVM.rst
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/JSONNodeDumper.cpp
    M clang/lib/AST/TextNodeDumper.cpp
    M clang/test/AST/HLSL/this-reference-template.hlsl
    M clang/test/AST/ast-dump-APValue-anon-union.cpp
    M clang/test/AST/ast-dump-APValue-struct.cpp
    M clang/test/AST/ast-dump-APValue-union.cpp
    M clang/test/AST/ast-dump-attr.cpp
    M clang/test/AST/ast-dump-decl-json.c
    M clang/test/AST/ast-dump-decl-json.m
    M clang/test/AST/ast-dump-decl.cpp
    M clang/test/AST/ast-dump-decl.m
    M clang/test/AST/ast-dump-expr-json.c
    M clang/test/AST/ast-dump-expr-json.cpp
    M clang/test/AST/ast-dump-expr-json.m
    M clang/test/AST/ast-dump-expr.c
    M clang/test/AST/ast-dump-expr.cpp
    M clang/test/AST/ast-dump-fpfeatures.cpp
    M clang/test/AST/ast-dump-funcs.cpp
    M clang/test/AST/ast-dump-functionprototype.cpp
    M clang/test/AST/ast-dump-lambda.cpp
    M clang/test/AST/ast-dump-objc-arc-json.m
    M clang/test/AST/ast-dump-openmp-begin-declare-variant_reference.cpp
    M clang/test/AST/ast-dump-openmp-begin-declare-variant_template_1.cpp
    M clang/test/AST/ast-dump-openmp-begin-declare-variant_template_2.cpp
    M clang/test/AST/ast-dump-openmp-begin-declare-variant_template_3.cpp
    M clang/test/AST/ast-dump-overloaded-operators.cpp
    M clang/test/AST/ast-dump-records-json.cpp
    M clang/test/AST/ast-dump-records.cpp
    M clang/test/AST/ast-dump-recovery.cpp
    M clang/test/AST/ast-dump-stmt-json.cpp
    M clang/test/AST/ast-dump-stmt.cpp
    M clang/test/AST/ast-dump-stmt.m
    M clang/test/AST/ast-dump-template-decls-json.cpp
    M clang/test/AST/ast-dump-template-decls.cpp
    M clang/test/AST/ast-dump-template-json-win32-mangler-crash.cpp
    M clang/test/AST/ast-dump-temporaries-json.cpp
    M clang/test/AST/ast-dump-types-json.cpp
    M clang/test/AST/coroutine-locals-cleanup.cpp
    M clang/test/AST/float16.cpp
    M clang/test/AST/nrvo.c
    M clang/test/AST/sourceranges.cpp
    M clang/test/C/drs/dr253.c
    M clang/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p4-ast.cpp
    M clang/test/Import/objc-param-decl/test.m
    M clang/test/OpenMP/align_clause_ast_print.cpp
    M clang/test/OpenMP/generic_loop_ast_print.cpp
    M clang/test/OpenMP/scope_ast_print.cpp
    M clang/test/SemaCXX/co_await-ast.cpp
    M clang/test/SemaCXX/consteval-cleanup.cpp
    M clang/test/SemaOpenCLCXX/address-space-deduction.clcpp
    M clang/test/SemaOpenCLCXX/addrspace-auto.clcpp
    M clang/test/SemaTemplate/aggregate-deduction-candidate.cpp
    M clang/test/SemaTemplate/deduction-guide.cpp
    M clang/test/SemaTemplate/default-expr-arguments-3.cpp
    M clang/test/SemaTemplate/make_integer_seq.cpp
    M clang/test/SemaTemplate/pr47676.cpp
    M clang/test/SemaTemplate/type_pack_element.cpp
    M clang/unittests/AST/ASTImporterTest.cpp

  Log Message:
  -----------
  [AST] Only dump desugared type when visibly different (#65214)

These are an artifact of how types are structured but serve little
purpose, merely showing that the type is sugared in some way. For
example, ElaboratedType's existence means struct S gets printed as
'struct S':'struct S' in the AST, which is unnecessary visual clutter.
Note that skipping the second print when the types have the same string
matches what we do for diagnostics, where the aka will be skipped.