[all-commits] [llvm/llvm-project] 35baff: [AMDGPU] Correct assert that incorrectly chained m...

Craig Topper via All-commits all-commits at lists.llvm.org
Thu Oct 26 08:02:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 35baff8b6ac4630d28db91d6b481d6cd5910931e
      https://github.com/llvm/llvm-project/commit/35baff8b6ac4630d28db91d6b481d6cd5910931e
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp

  Log Message:
  -----------
  [AMDGPU] Correct assert that incorrectly chained multiple == operators. (#70291)

I believe this assert was trying to check that 3 variables were equal to
0.

I think it instead got interpreted as ((DSWCount == DSWWithPermCount) ==
DSWWithSharedVMEMCount) == 0 I guess (DSWCount == DSWWithPermCount) was
true because both counts were 0. Then true got compared to
DSWWithSharedVMEMCount, and since DSWWithSharedVMEMCount is 0, that
compare was false. And then that false compared equal to the final 0.




More information about the All-commits mailing list