[all-commits] [llvm/llvm-project] fa1882: [Driver] Remove some misused NoXarchOption

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Oct 25 20:59:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fa18827754ebdd144f41fd4a889016c8ae1caf0c
      https://github.com/llvm/llvm-project/commit/fa18827754ebdd144f41fd4a889016c8ae1caf0c
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M clang/include/clang/Driver/Options.td

  Log Message:
  -----------
  [Driver] Remove some misused NoXarchOption

If an option has the `NoXarchOption` flag, ClangDriver will emit an error if the
option is used after `-Xarch_*` (originally for universal macOS binary, reused
by offloading purposes `-Xarch_host`/etc). The error checking only applies to a
small set of options (e.g. `-o`) and is not very useful for most options, but
`NoXarchOption` was improperly named `DriverOption` (commit
aabb0b11a3c1d8a6bb859db80400cffdcc9b336f) and lured some contributors to add
`NoXarchOption` to options that should not have the flag.




More information about the All-commits mailing list