[all-commits] [llvm/llvm-project] d8a521: [mlir][doc] Slightly clarify bufferization documen...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Wed Oct 25 20:44:30 PDT 2023


  Branch: refs/heads/users/joker-eph/dps-doc
  Home:   https://github.com/llvm/llvm-project
  Commit: d8a5215728322d1c72bafa6c84cd54936102b174
      https://github.com/llvm/llvm-project/commit/d8a5215728322d1c72bafa6c84cd54936102b174
  Author: Rik Huijzer <github at huijzer.xyz>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M mlir/docs/Bufferization.md

  Log Message:
  -----------
  [mlir][doc] Slightly clarify bufferization documentation (#70212)

I was reading through the very well written Destination-Passing Style
docs. Even though I know not much about compilers, I managed to
understand it pretty well. A few things tripped me up though, which this
PR suggests to rewrite:

1. Write `buffer(%0)` instead of buffer(`%0`). While reading, I first
interpreted the text as "the buffer (%0)", whereas it should be
interpreted as pseudocode for "a function that determines the buffer
applied to %0". Quickly introducing it and moving the backticks around
as this PR does should make this more clear. Also, I verified that MLIR
does not contain any other occurences of `"buffer(<BACKTICK>"`. It does
contain many occurences of `"buffer("` (without the backtick after the
opening bracket), so this PR makes notation a bit more consistent.
2. Quotation marks slowed me down during reading, so I removed them. I
think it's also clear without.
3. The `outs` from `linalg` was suddenly introduced. I've tried to
clarify in as few words as possible that `outs` stands for `outputs` but
suggestions are welcome.


  Commit: 44193a0573d82c1c353a25b73acc338663095c80
      https://github.com/llvm/llvm-project/commit/44193a0573d82c1c353a25b73acc338663095c80
  Author: Wang Pengcheng <wangpengcheng.pp at bytedance.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M llvm/utils/TableGen/CompressInstEmitter.cpp

  Log Message:
  -----------
  [TableGen][NFC] Format CompressInstEmitter (#68564)

Format code, fix linter warnings and format comments.


  Commit: f09f58d0f2a981d8d578c66fbd1f27709ee6dfda
      https://github.com/llvm/llvm-project/commit/f09f58d0f2a981d8d578c66fbd1f27709ee6dfda
  Author: Yuanfang Chen <tabloid.adroit at gmail.com>
  Date:   2023-10-26 (Thu, 26 Oct 2023)

  Changed paths:
    M openmp/libompd/gdb-plugin/CMakeLists.txt

  Log Message:
  -----------
  [OpenMP] [OMPD] Fix CMake install command

https://cmake.org/cmake/help/latest/command/install.html
"If a relative path is given it is interpreted relative to the value of the CMAKE_INSTALL_PREFIX variable."


  Commit: f40ed134b485db5f950f51a0d175caffe607b2f1
      https://github.com/llvm/llvm-project/commit/f40ed134b485db5f950f51a0d175caffe607b2f1
  Author: Kazu Hirata <kazu at google.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M clang/lib/Driver/Driver.cpp

  Log Message:
  -----------
  [Driver] Use StringSet::contains (NFC)


  Commit: fcdb098737949b325bc4e8aee21810a7a949c1a6
      https://github.com/llvm/llvm-project/commit/fcdb098737949b325bc4e8aee21810a7a949c1a6
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M clang/lib/Driver/Driver.cpp
    M llvm/utils/TableGen/CompressInstEmitter.cpp
    M mlir/docs/Bufferization.md
    M openmp/libompd/gdb-plugin/CMakeLists.txt

  Log Message:
  -----------
  Merge branch 'main' into users/joker-eph/dps-doc


Compare: https://github.com/llvm/llvm-project/compare/a06bcdde0c75...fcdb09873794


More information about the All-commits mailing list