[all-commits] [llvm/llvm-project] 10508b: [LLDB][NFC] Remove DWARFASTParserClang as friend f...

Walter Erquinigo via All-commits all-commits at lists.llvm.org
Wed Oct 25 15:04:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10508b6db72d8ee4ef022b85fe51c671921088f3
      https://github.com/llvm/llvm-project/commit/10508b6db72d8ee4ef022b85fe51c671921088f3
  Author: Walter Erquinigo <a20012251 at gmail.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h

  Log Message:
  -----------
  [LLDB][NFC] Remove DWARFASTParserClang as friend from SymbolFileDWARF (#70157)

This effectively moves a few functions from protected to public. In any
case, for the sake of having a cleaner SymbolFileDWARF API, it's better
if it's not a friend of a one of its consumers, DWARFASTParserClang.
Another effect of this change is that I can use SymbolFileDWARF for the
out-of-tree mojo dwarf parser, which relies on pretty much the same
functions that DWARFASTParserClang needs from SymbolFileDWARF.




More information about the All-commits mailing list