[all-commits] [llvm/llvm-project] 22f121: [SelectionDAG] Salvage debug info for non-constant...

David Stenberg via All-commits all-commits at lists.llvm.org
Wed Oct 25 08:04:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 22f1217932e11672a337e0a5504cd5b2eb3fedf8
      https://github.com/llvm/llvm-project/commit/22f1217932e11672a337e0a5504cd5b2eb3fedf8
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2023-10-25 (Wed, 25 Oct 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    A llvm/test/DebugInfo/Sparc/pointer-add-unknown-offset-debug-info.ll

  Log Message:
  -----------
  [SelectionDAG] Salvage debug info for non-constant ADDs (2nd try) (#68981)

Teach SelectionDAG::salvageDebugInfo() to salvage debug information for
ADD nodes where the RHS is non-constant.

In the first try, the test case used the MIR output that was produced by
using -stop-before=sparc-isel. Running -start-before=sparc-isel on that
output resulted in the following verifier error with EXPENSIVE_CHECKS:

  "Function has NoVRegs property but there are VReg operands".

In this re-attempt the test case has been rewritten to a .ll test by
extracting the IR from the original MIR file. The test still starts
before sparc-isel.

Co-authored-by: Mikael Holmen <mikael.holmen at ericsson.com>




More information about the All-commits mailing list