[all-commits] [llvm/llvm-project] f41831: Reland "[clang][Sema] Use original template patter...

[antangelo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f418319730341e9d41ce8ead6fbfe5603c343985
      https://github.com/llvm/llvm-project/commit/f418319730341e9d41ce8ead6fbfe5603c343985
  Author: antangelo <contact at antangelo.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Sema/SemaTemplate.cpp
    M clang/test/SemaTemplate/nested-deduction-guides.cpp
    A clang/test/SemaTemplate/nested-implicit-deduction-guides.cpp

  Log Message:
  -----------
  Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (#69676)

Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0

When a nested template is instantiated, the template pattern of the
inner class is not copied into the outer class
ClassTemplateSpecializationDecl. The specialization contains a
ClassTemplateDecl with an empty record that points to the original
template pattern instead.

As a result, when looking up the constructors of the inner class, no
results are returned. This patch finds the original template pattern and
uses that for the lookup instead.

Based on CWG2471 we must also substitute the known outer template
arguments when creating deduction guides for the inner class.

Changes from the last iteration:
1. The outer retained levels from the outer template are always added to
the `MultiLevelTemplateArgumentList` for rewriting
`FunctionTemplateDecl` arguments, even if there is no FTD and the
arguments are empty.
2. When building implicit deduction guides, the template pattern
underlying decl is pushed as the current context. This resolves the
issue where `FindInstantiatedDecl` is unable to find the inner template
class.
3. Tests are updated to cover the failing case, and to assert that the
type is correct after argument deduction in the implicit case.