[all-commits] [llvm/llvm-project] 8a57bc: [mlir][tosa] Add verifiers to ReduceOps, fix shape...

Felix Schneider via All-commits all-commits at lists.llvm.org
Tue Oct 24 10:53:51 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a57bc092850d6a5fa43a7f74a04352bb135f56e
      https://github.com/llvm/llvm-project/commit/8a57bc092850d6a5fa43a7f74a04352bb135f56e
  Author: Felix Schneider <fx.schn at gmail.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
    M mlir/lib/Dialect/Tosa/IR/TosaOps.cpp
    M mlir/test/Dialect/Tosa/canonicalize.mlir
    M mlir/test/Dialect/Tosa/invalid.mlir

  Log Message:
  -----------
  [mlir][tosa] Add verifiers to ReduceOps, fix shape inference crash (#69843)

This patch adds verifiers to `tosa.reduce_*` ops that check, among other things,
that the supplied `axis` argument is compatible with the input/output tensors'
shapes. We allow for a special case of `axis == 0 && rank == 0` to be valid.
This patch also adds a check to `ReduceInferReturnTypes()` to ensure that the
shape inference pass doesn't crash on an invalid `axis` argument anymore.

Fix https://github.com/llvm/llvm-project/issues/68187




More information about the All-commits mailing list