[all-commits] [llvm/llvm-project] 945e94: [AMDGPU] Fix subreg check in the SIFixSGPRCopies (...

Stanislav Mekhanoshin via All-commits all-commits at lists.llvm.org
Tue Oct 24 01:45:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 945e943db773e9f42da9cf9811d32f86a60158a1
      https://github.com/llvm/llvm-project/commit/945e943db773e9f42da9cf9811d32f86a60158a1
  Author: Stanislav Mekhanoshin <rampitec at users.noreply.github.com>
  Date:   2023-10-24 (Tue, 24 Oct 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIFixSGPRCopies.cpp
    M llvm/test/CodeGen/AMDGPU/fix-sgpr-copies.mir
    M llvm/test/CodeGen/AMDGPU/phi-vgpr-input-moveimm.mir

  Log Message:
  -----------
  [AMDGPU] Fix subreg check in the SIFixSGPRCopies (#70007)

It checks for the copy of subregs, but it checks destination which may
never happen in SSA. It misses the subreg check and happily produces
S_MOV_B64 out of a subreg COPY.

The affected test should have never been formed in the first place
because the pass is running in SSA and copies into a subreg shall never
happen.




More information about the All-commits mailing list