[all-commits] [llvm/llvm-project] f8d448: Correct behavior of VLA extension diagnostic in C8...

[Aaron Ballman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f8d448d5e587a23886c3226957f880146a4d8c69
      https://github.com/llvm/llvm-project/commit/f8d448d5e587a23886c3226957f880146a4d8c69
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/test/Misc/warning-wall.c
    A clang/test/Sema/vla-ext.c

  Log Message:
  -----------
  Correct behavior of VLA extension diagnostic in C89 mode

Post-commit feedback (https://reviews.llvm.org/D156565#4654773) found
that the changes in 84a3aadf0f2483dde0acfc4e79f2a075a5f35bd1 caused us
to diagnose use of VLAs in C89 mode by default which was an unintended
change.

This adds -Wvla-cxx-extension as a warning group and adds the C++-
specific warnings to it while leaving the C warnings under
-Wvla-extension. -Wvla-cxx-extension is then added to -Wall.