[all-commits] [llvm/llvm-project] 538b7b: Reland [clang] [unittest] Add a test for Generic_G...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Oct 20 13:34:49 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90
      https://github.com/llvm/llvm-project/commit/538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M clang/unittests/Driver/CMakeLists.txt
    A clang/unittests/Driver/GCCVersionTest.cpp

  Log Message:
  -----------
  Reland [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)

This adds actual test cases for all the cases that are listed in a code
comment in the implementation of this function; having such test
coverage eases doing further modifications to the function.

This relands b4b35a5d2b4ee26bf79b8a92715dd200f3f9cc49. This time,
the new test is excluded if building with dylibs or shared libraries
enabled, as the clang::toolchains::Generic_GCC class is marked
LLVM_LIBRARY_VISIBILITY, giving it hidden visibility in such builds,
making it unreferencable outside of the dylib/shared library.




More information about the All-commits mailing list