[all-commits] [llvm/llvm-project] 09ec00: [Modules] textual headers in submodules never reso...

Ian Anderson via All-commits all-commits at lists.llvm.org
Fri Oct 20 13:23:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 09ec0004eee2d9929d25cf519956cc470ffb33dd
      https://github.com/llvm/llvm-project/commit/09ec0004eee2d9929d25cf519956cc470ffb33dd
  Author: Ian Anderson <iana at apple.com>
  Date:   2023-10-20 (Fri, 20 Oct 2023)

  Changed paths:
    M clang/lib/Lex/ModuleMap.cpp
    A clang/test/Modules/no-undeclared-includes.c

  Log Message:
  -----------
  [Modules] textual headers in submodules never resolve their `use`s (#69651)

When an include from a textual header is resolved, the textual header's
submodule is used as the requesting module. The submodule's uses are
resolved, but that doesn't work because only top level modules have
uses, and only the top level module uses are used for checking uses in
Module::directlyUses. ModuleMap::resolveUses to resolve the top level
module instead of the submodule.




More information about the All-commits mailing list