[all-commits] [llvm/llvm-project] 4b13c8: [ORC] Fix heap-use-after-free error in MachODebugO...

[Jeff Niu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b13c86d980af81fb9badc1b6b88f77f4faf5e53
      https://github.com/llvm/llvm-project/commit/4b13c86d980af81fb9badc1b6b88f77f4faf5e53
  Author: Mogball <jeff at modular.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M llvm/lib/ExecutionEngine/Orc/Debugging/DebuggerSupportPlugin.cpp

  Log Message:
  -----------
  [ORC] Fix heap-use-after-free error in MachODebugObjectSynthesizer.cpp

At line 191, `addSymbol` takes the name by reference but does not make
an internal copy to the string, meaning the local
`optional<std::string>` would get freed and leave Orc with a dangling
pointer. Fix this by just using an `optional<StringRef>` instead.