[all-commits] [llvm/llvm-project] 0463e0: [mlir][ROCDL] Fix file leak in SeralizeToHsaco and...

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Fri Sep 29 15:24:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0463e00ac618654a6ea9d690cb0830530ad319a1
      https://github.com/llvm/llvm-project/commit/0463e00ac618654a6ea9d690cb0830530ad319a1
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M mlir/lib/Dialect/GPU/Transforms/SerializeToHsaco.cpp
    M mlir/lib/Target/LLVM/ROCDL/Target.cpp

  Log Message:
  -----------
  [mlir][ROCDL] Fix file leak in SeralizeToHsaco and its newer form (#67711)

SerializetToHsaco, as currently implemented, leaks the file descriptor
of the .hsaco temporary file, which causes issues in long-running
parallel compilation setups.

See also https://github.com/ROCmSoftwarePlatform/rocMLIR/pull/1257




More information about the All-commits mailing list