[all-commits] [llvm/llvm-project] 5d8766: Revert #67745 "[asan] Ensure __asan_register_elf_g...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d87665de956eaa237def9c7a35c449e71629302
      https://github.com/llvm/llvm-project/commit/5d87665de956eaa237def9c7a35c449e71629302
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
    M llvm/test/Instrumentation/AddressSanitizer/basic.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata_array.ll

  Log Message:
  -----------
  Revert #67745 "[asan] Ensure __asan_register_elf_globals is called in COMDAT asan.module_ctor (#67745)"

This reverts commit 1a4b9b6f73391d94f4f96cc964cbf89cfdd59b5b.

When getUniqueModuleId(&M) is empty, we may add comdat to internal constants
like $.str, causing spurious `error: relocation refers to a symbol in a
discarded section` lld errors.