[all-commits] [llvm/llvm-project] ec9d80: [ci] Diff against main when determining what files...

Louis Dionne via All-commits all-commits at lists.llvm.org
Fri Sep 29 07:25:02 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec9d80ec43f5761a34c4a785c67d9e7d21ec8bda
      https://github.com/llvm/llvm-project/commit/ec9d80ec43f5761a34c4a785c67d9e7d21ec8bda
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M .ci/generate-buildkite-pipeline-premerge

  Log Message:
  -----------
  [ci] Diff against main when determining what files have changed for pre-commit CI (#67743)

Since we moved to Github PRs, the workflow has changed a bit and folks
often merge `main` back into their PR branch. This is fine, except the
previous way of determining modified files for pre-commit CI would use
the content modified just in the latest commit, whatever it is. This
means that in case someone merged main back into their PR branch, we'd
think that the files in the merge commit were modified by the PR, and
we'd spuriously trigger a CI run. This should fix this issue.

The downside is that the merge target is hardcoded to `main`, which
might not always be what we want. I still think this is an improvement
over the status quo.




More information about the All-commits mailing list